search

angular / angularfire

Angular + Firebase = ❤️
https://firebaseopensource.com/projects/angular/angularfire2
MIT License
7.64k stars 2.2k forks source link

Won't build with Angular 10 #2526

Closed shadow1349 closed 3 years ago

shadow1349 commented 4 years ago

When I try to build or run my project it won't do either. It says that ModuleWithProviders<T> requires 1 type argument (screenshot attached below).

Version info

Angular: 10.0.1

Firebase: 7.15.1

AngularFire: 6.0.2

Other (e.g. Ionic/Cordova, Node, browser, operating system):

How to reproduce these conditions

Create an Angular 10 project (with @angular/core version 10.0.1). Add @angular/fire libary. Try to build.

Expected behavior

I should be able to build and run the project.

Actual behavior

Screenshot from 2020-06-26 23-42-45

shadow1349 commented 4 years ago

I tried downgrading to 10.0.0 and I got the same behavior.

MC-Mihai commented 4 years ago

You may want to check this link . It seems to me like support is only offered up to 8, but I could be wrong.

shadow1349 commented 4 years ago

@Mihai-MCW according to their changelog, 6.0.2 should work on angular 10 https://github.com/angular/angularfire/blob/master/CHANGELOG.md

fritzschoff commented 4 years ago

+1

yasinkocak commented 4 years ago

I made a PR for this #2527

shadow1349 commented 4 years ago

@yasinkocak thank you!

doivosevic commented 4 years ago

I have the same problem. Can I just copy paste this here firestore.module.d.ts:7:74 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s). because this is how I googled for the issue and didn't get any results

BianchiSeb commented 4 years ago

Hello angularFire team. I literally spend a ton of money in your app for my clients. At least answer us. It’s a shame that core features are broken. It’s a shame you don’t manage the PR. At least give us back the projets lead and we can manage it like a TRUE open source project.

kaptain-ti commented 4 years ago

set enableIvy to true in tsconfig and tsconfig.app

shadow1349 commented 3 years ago

@kaptain-ti I had to turn that off because I was using a custom decorator which is not supported by Ivy yet. If that issue is fixed in angular 10 then I will be able to turn ivy back on

vtregner-cen29414 commented 3 years ago

Fix is already merged to master, but not released. Can you release new version? Due this issue I cannot update my library to Angular 10...

doivosevic commented 3 years ago

Wow, over 1 month for a type fix

shadow1349 commented 3 years ago

@vtregner you can install the canary version npm i @angular/fire@canary that has the fix in and is fully working.

hlpupo commented 3 years ago

I have the same problem, any update?

fritzschoff commented 3 years ago

@hlpupo like @shadow1349 suggested, use the canary version. npm i @angular/fire@canary

djabif commented 3 years ago

Is there an estimated date for releasing 6.0.3?

Fix is already merged to master, but not released. Can you release new version? Due this issue I cannot update my library to Angular 10...

taylormills commented 3 years ago

The fix for this was merged over 2 months ago, what's the hold up on releasing? I would rather not have production code relying on a canary version.

doivosevic commented 3 years ago

@davideast @jeffbcross can we in any way help speed up the process in general? I would really like to help blockers like these go into production code sooner. Angular 11 is around the corner and we still cannot build all stable libraries with 10

vtregner-cen29414 commented 3 years ago

It seems the project is dead. Unbelievable ignorance.

Splaktar commented 3 years ago

With the fix for https://github.com/angular/angularfire/issues/2505 getting into the latest Canary, it looks like (based on https://github.com/angular/angularfire/issues/2505#issuecomment-698097239) that a 6.0.3 release is coming very soon.

Splaktar commented 3 years ago

I found another place where ModuleWithProviders is needed and fixed it in PR: https://github.com/angular/angularfire/pull/2598.