search

angular / angularfire

Angular + Firebase = ❤️
https://firebaseopensource.com/projects/angular/angularfire2
MIT License
7.66k stars 2.19k forks source link

Add support for getting document's id in CollectionGroupQuery #2579

Closed simonxabris closed 3 years ago

simonxabris commented 3 years ago

Version info

Angular: 9.1.6

Firebase: 7.15.0

AngularFire: 6.02

Hi!

I'm using angularfire on a project and I've tried to use collectionGroup.valueChanges({ idField: 'docId' }) to retrieve a collection group with the document ids mapped to the docId property as I saw in the docs. When I tried this, TS complained that the valueChanges function does not expect any arguments, so I took a quick look at the source and found out that the implementation is missing.

I'll be providing a PR with the implementation of this shortly.

jamesdaniels commented 3 years ago

Addressed in 6.1 :)

simonxabris commented 3 years ago

Thank you for merging!