search

angular / angularjs.org

code for angularjs.org site
http://angularjs.org/
MIT License
258 stars 189 forks source link

CSS issues on the download button? #213

Closed naomiblack closed 7 years ago

naomiblack commented 7 years ago

On my macbook air at standard width, the download button looks like this: image

Looks like a CSS issue?

@petebacondarwin @alexwolfe

alexwolfe commented 7 years ago

I'll take a look and address it with the other changes I'm making. Thanks.

On Fri, Jan 27, 2017 at 4:31 PM, Naomi Black notifications@github.com wrote:

On my macbook air at standard width, the download button looks like this: [image: image] https://cloud.githubusercontent.com/assets/2286589/22392437/05767318-e4ae-11e6-9fff-f38936df41c1.png

Looks like a CSS issue?

@petebacondarwin https://github.com/petebacondarwin @alexwolfe https://github.com/alexwolfe

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angular/angularjs.org/issues/213, or mute the thread https://github.com/notifications/unsubscribe-auth/AAY2xfKw8tCCAJWWx5o2vLJbU3P2GLNgks5rWoxmgaJpZM4LwWy_ .

petebacondarwin commented 7 years ago

This was my fault when fixing up the e2e tests. It has now been resolved.

alexwolfe commented 7 years ago

Yup, found another bug that was introduced, a max width of 300px (arbitrary) that was added to the search bar. I'm removing that as it not only interferes with the design (making it look really bad on desktop) it also breaks mobile.

On Sat, Jan 28, 2017 at 8:58 AM, Pete Bacon Darwin <notifications@github.com

wrote:

Closed #213 https://github.com/angular/angularjs.org/issues/213.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angular/angularjs.org/issues/213#event-940313898, or mute the thread https://github.com/notifications/unsubscribe-auth/AAY2xYCSs5osyjYyA-98BYCCSIbM3HZIks5rW3OygaJpZM4LwWy_ .

alexwolfe commented 7 years ago

Ok, added the site notice and addressed a few mobile issues that popped up. PR is here and ready for review. Thanks.

https://github.com/angular/angularjs.org/pull/214

On Sun, Jan 29, 2017 at 12:05 AM, Alex Wolfe thewolfe@gmail.com wrote:

Yup, found another bug that was introduced, a max width of 300px (arbitrary) that was added to the search bar. I'm removing that as it not only interferes with the design (making it look really bad on desktop) it also breaks mobile.

On Sat, Jan 28, 2017 at 8:58 AM, Pete Bacon Darwin < notifications@github.com> wrote:

Closed #213 https://github.com/angular/angularjs.org/issues/213.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angular/angularjs.org/issues/213#event-940313898, or mute the thread https://github.com/notifications/unsubscribe-auth/AAY2xYCSs5osyjYyA-98BYCCSIbM3HZIks5rW3OygaJpZM4LwWy_ .

petebacondarwin commented 7 years ago

I added the 300px maxwidth because there were complaints it was too wide on desktop. Your fix will need to address that.

alexwolfe commented 7 years ago

Where were the complaints coming from? Was it a design complaint or usability issue? I'll look into it but from a design standpoint it's more balanced and inline with other material sites.

On Sun, Jan 29, 2017 at 11:23 AM Pete Bacon Darwin notifications@github.com wrote:

I added the 300px maxwidth because there were complaints it was too wide on desktop. Your fix will need to address that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angular/angularjs.org/issues/213#issuecomment-275938964, or mute the thread https://github.com/notifications/unsubscribe-auth/AAY2xRC2BTK2UBMKvUCUQEdBduUuZg6Uks5rXOdAgaJpZM4LwWy_ .

alexwolfe commented 7 years ago

Can you forward me the complaints or direct the person my way, should make it easier to address this properly and give me the context for the problem. Thanks.

Alex On Sun, Jan 29, 2017 at 11:45 AM Alex Wolfe thewolfe@gmail.com wrote:

Where were the complaints coming from? Was it a design complaint or usability issue? I'll look into it but from a design standpoint it's more balanced and inline with other material sites.

On Sun, Jan 29, 2017 at 11:23 AM Pete Bacon Darwin < notifications@github.com> wrote:

I added the 300px maxwidth because there were complaints it was too wide on desktop. Your fix will need to address that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angular/angularjs.org/issues/213#issuecomment-275938964, or mute the thread https://github.com/notifications/unsubscribe-auth/AAY2xRC2BTK2UBMKvUCUQEdBduUuZg6Uks5rXOdAgaJpZM4LwWy_ .

petebacondarwin commented 7 years ago

Primarily @igorminar but I agree it looked very wide. It almost filled the toolbar.

On Sun, 29 Jan 2017, 19:49 Alex Wolfe, notifications@github.com wrote:

Can you forward me the complaints or direct the person my way, should make it easier to address this properly and give me the context for the problem. Thanks.

Alex On Sun, Jan 29, 2017 at 11:45 AM Alex Wolfe thewolfe@gmail.com wrote:

Where were the complaints coming from? Was it a design complaint or usability issue? I'll look into it but from a design standpoint it's more balanced and inline with other material sites.

On Sun, Jan 29, 2017 at 11:23 AM Pete Bacon Darwin < notifications@github.com> wrote:

I added the 300px maxwidth because there were complaints it was too wide on desktop. Your fix will need to address that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/angular/angularjs.org/issues/213#issuecomment-275938964 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAY2xRC2BTK2UBMKvUCUQEdBduUuZg6Uks5rXOdAgaJpZM4LwWy_

.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/angular/angularjs.org/issues/213#issuecomment-275940701, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA9J56QN330au5lBZFu8-8s-DpUELgeks5rXO03gaJpZM4LwWy_ .

alexwolfe commented 7 years ago

Ok, thanks for the background. Lets try to address these in the original PR in the future, that will allow me to address issues related to my branch and reduce turnaround and reduce new bugs. My plan for this is:

Move the search to the right side and reduce the width, this should accomplish two things:

  1. The navigation links will always be in view and the same location (flush left) regardless of screen width.
  2. This will be consistent with the other google dev sites.

@IgorMinar let me know if that sounds right, if you need a design mock before implementation, let me know. Thanks.