angular / batarang

AngularJS WebInspector Extension for Chrome
MIT License
2.43k stars 338 forks source link

Hide.js console.logs should be opt-in #179

Closed sangel10 closed 9 years ago

sangel10 commented 9 years ago

I had to uninstall the extension as I was getting too many logs while at work, also most of the logs were coming from my vendor directory for modules that I was not responsible for. Just a heads up that maybe these should be opt-in.

bengarvey commented 9 years ago

Agreed. I went into panic mode this morning with all that console output plus other issues with our app until I realized it was due to the extension update. I had to disable batarang for now.

nkpz commented 9 years ago

I assume you mean hint.js - I was also startled by the sudden changes. I would be in favor of it being opt-out, but now that I know where it's coming from I don't mind. I often hear complaints about how hard it is to figure out what the best practices are when building an Angular project, and I think this addresses it, but it is disruptive when it starts happening out of nowhere.

edit: I just thought I had some major performance issues in my app, then profiled it to find that Batarang was spending around 1000ms spitting out hints. That's a problem. Again, very much in favor of the idea but it's off to a rocky start unfortunately

jrthib commented 9 years ago

I had to disable as well. Our app wouldn't run after the update, though the logs seem useful.

c0bra commented 9 years ago

Dittos. Had to disable because hint.js started throwing exceptions. Seems like there's a check for whether controller names are camel-cased or not and the argument it was receiving was an object and not a string.

darwayne commented 9 years ago

+1 it breaks my angular apps

mg1075 commented 9 years ago

+1 Batarang just broke my app.

Splaktar commented 9 years ago

Duplicate of #158 and #159

You can find steps to rollback to a working version temporarily here: http://stackoverflow.com/a/27404493/633107

the-simian commented 9 years ago

FYI, The rest of batarang seems to be broken as well for me.

btford commented 9 years ago

Console messages removed via https://github.com/angular/angular-hint/commit/160b15bf935ee7e3ef8b1d233ff6085d0a6b017a

These changes are in a v0.6.1 release that I just pushed.