angular / batarang

AngularJS WebInspector Extension for Chrome
MIT License
2.43k stars 338 forks source link

bug: Controller as Syntax error v1.2.23 #187

Closed matt-newell closed 9 years ago

matt-newell commented 9 years ago

v1.2.23 and Cntrl As syntax is broken with the new Batarang update when Batarang is enabled

vijay-kr-bandi commented 9 years ago

+1, v1.3. Failing to locate global controllers also.

shonng commented 9 years ago

To be specific, line 651 expected the result from nameToControllerMap[] to be a function. In the case of "controller as" it will be a string which throws an error, stopping all other script execution on the page.

Splaktar commented 9 years ago

Duplicate of #163

btford commented 9 years ago

Can you please try with v0.7.3 and let me know if this persists?

matt-newell commented 9 years ago

This appears to be fixed! :100:

btford commented 9 years ago

Great! I'm going to close this, but if you run into anything else, don't hesitate to comment here or file another issue. Thanks for your help!

Splaktar commented 9 years ago

Confirmed that this is working for my app with Batarang 0.7.4 and 'Controller as' as well.