feat(messaging): Switch to postMessage

angular / batarang

AngularJS WebInspector Extension for Chrome

MIT License

2.43k stars 338 forks source link

feat(messaging): Switch to postMessage #214

Closed SomeKittens closed 9 years ago

SomeKittens commented 9 years ago

Previously, we used shared DOM by JSON.stringifying data and triggering an event. This commit switches to window.postMessage to avoid both stringification and dom manipulation

btford commented 9 years ago

:clap: looks good to me!

SomeKittens commented 9 years ago

There's some sort of race condition with npm install in our tests, ended up rerunning them until they passed.

btford commented 9 years ago

Tests that run in the browser are sometimes flakey. If you see timeouts, feel free to just re-run the tests.

You're welcome to merge this.

SomeKittens commented 9 years ago

Merged in f05431fe920d72488a379fac10329c0510ffdc26