fix(loader): support v1.6.3+ (and other fixes)

angular / batarang

AngularJS WebInspector Extension for Chrome

MIT License

2.43k stars 338 forks source link

fix(loader): support v1.6.3+ (and other fixes) #308

Closed gkalpak closed 7 years ago

gkalpak commented 7 years ago

Updated dependencies and configs.
Switched to yarn.
Added support for the angular.Module#info() method, necessary in v1.6.3+.

Fixes #307.

Narretz commented 7 years ago

The hint.js is copied from angular-hint. :)

gkalpak commented 7 years ago

Yes, hint.js is generated based on angular-hint's hint.js (as published on npm). I copied the latest loader.js from angular/agular.js and tweaked as necessary.

Batarang has some tests, but afaict they are about the DevTools panel, rather than how the extension interacts with AngularJS apps. So, stuff like that would not be caught.

gkalpak commented 7 years ago

Merged :grin: (Happy to address additional feedback/comments in follow-up PRs.)