angular / batarang

AngularJS WebInspector Extension for Chrome
MIT License
2.43k stars 338 forks source link

Allow to inspect Angular2+ component inspection #315

Closed yannickglt closed 7 years ago

yannickglt commented 7 years ago

The goal of this feature is to provide a very simple way to inspect an Angular component instance. It should be as easy as inspecting an AngularJS scope with Batarang. I think it will help users used to AngularJS and Batarang to start development and debug on Angular2+.

Example of Angular2 debugging with Batarang 2017-06-15_22-24-44

Related to https://github.com/angular/batarang/issues/235

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


yannickglt commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

yannickglt commented 7 years ago

@gary-b @gkalpak Is there something I should change to get this PR merged, or maybe this is not a wanted feature?

gkalpak commented 7 years ago

Sorry for taking so long to respond, @yannickglt. We discussed it internally and we think it will be more confusing than helpful. Besides, there is already Augury, which is excellent for exploring/debugging Angular applications.

It would be great if Batarang detected Angular apps and showed a message pointing the user to Augury for debugging Angular apps.

I am going to close this PR, since it is not a feature we want to include in Batarang, but you are more than welcome to open a new one for pointing to Augury :smiley:

yannickglt commented 7 years ago

It's OK! Thanks for answering anyway.

Actually, I already made a similar pull request on Augury but I guess the main contributors are as busy as you are because I could not get any reply for the moment.

I currently work with both Batarang and Augury and the main difference I can see is that Batarang is loaded in the elements panel, while Augury loads only when accessing its own panel. It means that I need to click on the Augury tab first, wait for the plugin to be loaded and then select a DOM element in the elements panel to be able to inspect my component. It's quite annoying and confusing 😕 and got me keep using Batarang and $scope for my Angular apps.