angular / closure-demo

MIT License
115 stars 27 forks source link

update code/doc to show closure-compiler js use instead of java dependent build process #35

Open nirajkrz opened 5 years ago

nirajkrz commented 5 years ago

Since we have different options available in google-closure-compiler (Java vs JS versions). Can we have an example to demonstrate it's use with Angular6+ versions using closure-compiler-js for UI projects? It would be helpful to showcase the integration and use of google-closure-compiler with the angular's (CLI vs 7 and above) build process and avoid the JAR dependency.

thelgevold commented 5 years ago

I have found the JS version to not be a realistic alternative. It runs out of memory and crashes for even just medium sized projects.

More context here: https://github.com/google/closure-compiler-js/issues/23

nirajkrz commented 5 years ago

Thanks for the reply @thelgevold. So that means we should be using the Java version only. Is there a workaround available to get the JS one working?

thelgevold commented 5 years ago

I am not aware of a workaround that makes it possible to rely on the JS version. The main issue is that it doesn't scale. I would stick to the Java version.