search

angular / code.angularjs.org

code.angularjs.org
151 stars 747 forks source link

Add system-polyfills for IE/Edge users #30

Closed robwormald closed 8 years ago

robwormald commented 8 years ago

See https://github.com/angular/angular/issues/5426

pkozlowski-opensource commented 8 years ago

Could we rather add es6 shim? See info copied over from https://github.com/angular/angular/issues/5426#issuecomment-158617554

The thing is that SystemJS will try to download polyffils for things like Promise etc. (which I really don't think it should be doing...). But it won't do it if things are needed are already available.

So imo a "proper" way of solving this is to include es6 shim before SystemJS - you will need those for IE anyway and it will prevent SystemJS from firing its XHR little thingy thus saving one round-trip to a server.

Deploying system-polyfills.js won't hurt but it might put users on sub-optimal track. So I would rather vote for deploying es6 shim.

tenowg commented 8 years ago

I will attempt again later, but I did look at the appendix on the 5 minute quick start, and tried to include es6shim and it still required system-polyfills and would fail to load the app.

tenowg commented 8 years ago

Attempting to add es6-shim will still fail without system-ployfills on Edge (not tested on lower versions)

below I show that es6-shim is loaded:

loaded

and also the attempt to load the system-polyfills:

notfound

this of course leads to this messge:

errormessage

So currently system-polyfills is required to get the quick start working for new users that don't want to have to jump through hoops to try out angular2