search

angular / code.angularjs.org

code.angularjs.org
153 stars 749 forks source link

Update ng.directive:ngAnimate.html #9

Closed philwestwell closed 10 years ago

philwestwell commented 10 years ago

Grammar - Depending on what the author meant, I think the sentence would be either "It affects how the directive will perform DOM manipulation." (it influences how the DOM manipulation is done) or "It effects the DOM manipulation by the directive" (it carries out the DOM manipulation) but not "It effects how the directive..." Proposing the version that I think reflects the author's intentions.

petebacondarwin commented 10 years ago

Great. Thanks. Can you submit this to the angular.js repository? On 24 May 2014 12:14, "westwell" notifications@github.com wrote:

Grammar - Depending on what the author meant, I think the sentence would be either "It affects how the directive will perform DOM manipulation." (it influences how the DOM manipulation is done) or "It effects the DOM manipulation by the directive" (it carries out the DOM manipulation) but not "It effects how the directive..."

Proposing the version that I think reflects the author's intentions.

You can merge this Pull Request by running

git pull https://github.com/philwestwell/code.angularjs.org patch-1

Or view, comment on, or merge it at:

https://github.com/angular/code.angularjs.org/pull/9 Commit Summary

  • Update ng.directive:ngAnimate.html

File Changes

  • M 1.1.5/docs/partials/api/ng.directive:ngAnimate.htmlhttps://github.com/angular/code.angularjs.org/pull/9/files#diff-0(2)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/angular/code.angularjs.org/pull/9 .

philwestwell commented 10 years ago

I don't think I have permissions to do that ... or do I? On 24 May 2014, at 12:36, Pete Bacon Darwin notifications@github.com wrote:

Great. Thanks. Can you submit this to the angular.js repository? On 24 May 2014 12:14, "westwell" notifications@github.com wrote:

Grammar - Depending on what the author meant, I think the sentence would be either "It affects how the directive will perform DOM manipulation." (it influences how the DOM manipulation is done) or "It effects the DOM manipulation by the directive" (it carries out the DOM manipulation) but not "It effects how the directive..."

Proposing the version that I think reflects the author's intentions.

You can merge this Pull Request by running

git pull https://github.com/philwestwell/code.angularjs.org patch-1

Or view, comment on, or merge it at:

https://github.com/angular/code.angularjs.org/pull/9 Commit Summary

  • Update ng.directive:ngAnimate.html

File Changes

  • M 1.1.5/docs/partials/api/ng.directive:ngAnimate.htmlhttps://github.com/angular/code.angularjs.org/pull/9/files#diff-0(2)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/angular/code.angularjs.org/pull/9 .

— Reply to this email directly or view it on GitHub.

philwestwell commented 10 years ago

Ah. Sorry Pete (embarrassed) - didn't look at who the email was to! On 24 May 2014, at 12:38, Philip Westwell Phil.Westwell@gmail.com wrote:

I don't think I have permissions to do that ... or do I? On 24 May 2014, at 12:36, Pete Bacon Darwin notifications@github.com wrote:

Great. Thanks. Can you submit this to the angular.js repository? On 24 May 2014 12:14, "westwell" notifications@github.com wrote:

Grammar - Depending on what the author meant, I think the sentence would be either "It affects how the directive will perform DOM manipulation." (it influences how the DOM manipulation is done) or "It effects the DOM manipulation by the directive" (it carries out the DOM manipulation) but not "It effects how the directive..."

Proposing the version that I think reflects the author's intentions.

You can merge this Pull Request by running

git pull https://github.com/philwestwell/code.angularjs.org patch-1

Or view, comment on, or merge it at:

https://github.com/angular/code.angularjs.org/pull/9 Commit Summary

  • Update ng.directive:ngAnimate.html

File Changes

  • M 1.1.5/docs/partials/api/ng.directive:ngAnimate.htmlhttps://github.com/angular/code.angularjs.org/pull/9/files#diff-0(2)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/angular/code.angularjs.org/pull/9 .

— Reply to this email directly or view it on GitHub.

petebacondarwin commented 10 years ago

You can fork https://github.com/angular/angular.js/ and submit there.

philwestwell commented 10 years ago

OK. I see now. Thanks On 24 May 2014, at 12:48, Pete Bacon Darwin notifications@github.com wrote:

You can fork https://github.com/angular/angular.js/ and submit there.

— Reply to this email directly or view it on GitHub.

petebacondarwin commented 10 years ago

Yes. This repository just stores historical versions of Angular.

philwestwell commented 10 years ago

Thanks. I was confused initially by the "improve this doc" feature on the doc page at the top of the Google search hits (https://code.angularjs.org/1.1.4/docs/api/ng.directive:ngAnimate), and then after your comment it dawned on me that this is an older page. So thanks for talking me through that.

Now I just have to find the page in the restructured documentation... On 24 May 2014, at 13:13, Pete Bacon Darwin notifications@github.com wrote:

Yes. This repository just stores historical versions of Angular.

— Reply to this email directly or view it on GitHub.