search

angular / dev-infra

Angular Development Infrastructure
MIT License
62 stars 52 forks source link

fix(github-actions): allow `Apache-2.0 AND BSD-3-Clause` license #2178

Closed alan-agius4 closed 1 month ago

alan-agius4 commented 1 month ago

google-protobuf is licensed under a combination of two licenses: Apache-2.0 and BSD-3-Clause.

devversion commented 1 month ago

Is there a way to only allow the given package?

alan-agius4 commented 1 month ago

Yes, via allow-dependencies-licenses not sure how to merge it with the input though. https://github.com/angular/dev-infra/blob/53c706164e66b6b574149064e392ba7553fb055e/github-actions/linting/licenses/action.yml#L21

devversion commented 1 month ago

Where is the action used? is this in angular-cli?

alan-agius4 commented 1 month ago

Where is the action used? is this in angular-cli?

For the time being, but recently it was moved here so it will be be rolled out on all the repos.

google-protobuf is used by bazel so it makes sense to add it here. IMHO.

devversion commented 1 month ago

Oh yeah, definitely makes sense to add, but I'm wondering if we can just allow it for e.g. @bazel/worker. Otherwise other dependencies with this license slip through, or is this a valid license in general?

alan-agius4 commented 1 month ago

It is a combination of 2 valid license. Both Apache-2.0 and BSD-3-Clause are allowed on their own.

devversion commented 1 month ago

LGTM then! — didn't notice that this is a valid one then.

angular-automatic-lock-bot[bot] commented 2 weeks ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.