angular / dev-infra

Angular Development Infrastructure
MIT License
62 stars 52 forks source link

ci: no longer use RBE executors for macos test, use macos-13 runner #2180

Closed josephperrott closed 1 month ago

josephperrott commented 1 month ago

Use the macos-13 runner as it uses an intel chip. Additionally, we realized we should not not be doing these executions on RBE as point is to test in a fully osx environment.

devversion commented 1 month ago

Hmm. should we really disable this? I feel like we often disable, but never re-enable fix. E.g. see worker in angular/components

josephperrott commented 1 month ago

@devversion PTAL as I found that it was based on the chip that was being used in the test, it seems that its misdetecting the correct type of chip somewhere in the process. Moving to use a runner with an x86 chip worked as expected.

josephperrott commented 1 month ago

This PR was merged into the repository by commit de8a879b1168657494ef108db3c24bbda806b39b.

The changes were merged into the following branches: main

angular-automatic-lock-bot[bot] commented 2 weeks ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.