search

angular / devkit

MIT License
546 stars 156 forks source link

update ng-packagr v3 #976

Closed dherges closed 6 years ago

alan-agius4 commented 6 years ago

Tip: Commit scope should be @angular-devkit/build-ng-packagr

dherges commented 6 years ago

Hi @filipesilva, i just updated the PR with the right commit message.

dherges commented 6 years ago

A general notice. ng-packagr@3 implements APF 6 (with both ESM's and FESM's) and should work for both Angular 5 and Angular 6.

In ng-packagr@4, there is the change for using enableResourceInlining in ngc and it thus requires the Angular compiler v6 (I think both @angular/compiler@6 and @angular/compiler-cli@6)

filipesilva commented 6 years ago

@dherges SGTM. Nice to hear about the enableResourceInlining option! I suppose it lets you remove a fair bit of inlining logic?

filipesilva commented 6 years ago

The current CI errors are unrelated to this PR I think:

Failures:
1) Schematic Update works with a fixed version
  Message:
    Failed: Unexpected end of JSON input
clydin commented 6 years ago

Please rebase on master

dherges commented 6 years ago

Hi there, I updated the version range for the peerDeps.

clydin commented 6 years ago

Can you use npm v6 to update the package lock? There is a large amount of noise in the diff