Closed gregmagolan closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
CLAs look good, thanks!
Thanks for this PR. Can you please provide tests for the new behaviour in https://github.com/gregmagolan/dgeni-packages/blob/e3916fddc92e4815b920101f573032918692e5c2/git/services/gitRepoInfo.spec.js
You should be able to run the tests via yarn test
Sounds good. I'll add to the test cases.
@gregmagolan - do you still have time to add the test cases here?
@petebacondarwin Thanks for the ping. This fell off my radar. I had some time today or tommorow.
Will reopen with tests and rebase to upstream master
Make gitRepoInfo() tolerant of internal repo URLs such as: http://foo.bar.net:7999/projects/web/repos/foo-bar-project