Closed haschu closed 7 years ago
I would definitely stick the tests in with this PR. But if you don't have time, don't worry. I can review both over the weekend.
There you go! You can close #233.
Agh! I only just noticed the commit messages. @haschu - in future PRs can you follow the same convention as we use in Angular: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Ahh... sorry for that! I've read too quickly and thought that those rules only apply to the PR. Won't happen again.
Closes #229 For tests see: #233