Closed dpogue closed 6 years ago
I think this does unfortunately change the API of TSParser, because UnderscoreEscapedMap
does not extend Map
and can't be casted :disappointed:
The APIs are the same, so we could hypothetically cast the UnderscoreEscapedMap
to any
and then back to Map
, but I think it would run into issues with the keys being __String
instead of string
.
Arguably the TsParser is an internal helper for the external API, which is really the API docs classes and the readTypeScriptModules processor. But to be on the safe side I am going to land this in a version that allows breaking changes.
Thanks @dpogue - I have rebased and fixed up this PR - landing it on master. I will release it as part of 0.26.0
Thanks @dpogue
Does this cause breaking changes for people using the
typescript
dgeni packages? I am concerned that we have changed the public API to TSParser with theUnderscoreEscapedMap
stuff.