search

angular / dgeni-packages

A collection of dgeni packages for generating documentation from source code.
MIT License
142 stars 106 forks source link

Add postProcessHtml package from angular.io #282

Closed BrunnerLivio closed 5 years ago

BrunnerLivio commented 5 years ago

It would be useful if the postProcessHtml functionality from the angular/angular repository would be its standalone thing. Mainly because I would love to reuse this functionality for nestjs/docs.nestjs.com and I think others would appreciate it too.

I am not quite sure if the package fits into dgeni-packages / dgeni or a separate repository. I guess this is up to you.

I would be willing to submit a PR, or maintain a separate repository.

petebacondarwin commented 5 years ago

It would go in here. Feel free to submit a PR. But be aware, that as soon as we move stuff in here the bar for reusability goes up. So it might not be enough to simply copy it over.

BrunnerLivio commented 5 years ago

@petebacondarwin Yup, will look out for that. One question before I start with the contribution; should the PR be written in TypeScript or JavaScript? The repository has mixed languages and I am not sure whether it is due to historical reasons, or just because of the typescript package.

petebacondarwin commented 5 years ago

Happy to accept TypeScript. The original dgeni was pre-TypwScript.

BrunnerLivio commented 5 years ago

@petebacondarwin done!