search

angular / dgeni-packages

A collection of dgeni packages for generating documentation from source code.
MIT License
142 stars 106 forks source link

fix(base): ensure writeFile() actually writes files to disk #288

Closed petebacondarwin closed 4 years ago

petebacondarwin commented 4 years ago

The mkdirp-promise dependency had its own dependency of "mkdirp": "*". But recently mkdirp did a new breaking change release that is no longer compatible with mkdirp-promise. This was causing the writeFile() service never to resolve its own promise, which resulted in files not getting written to the disk.

This commit removes the dependency on mkdirp-promise since mkdirp now supports returning a promise directly.

Fixes #287

wszgrcy commented 4 years ago

yes!!!! I trace many codes and find mkdirp has changed but the mkdirp-promise not lock version. fuck.......