search

angular / dgeni-packages

A collection of dgeni packages for generating documentation from source code.
MIT License
142 stars 106 forks source link

Test from the typescript package fails #297

Closed lmores closed 3 years ago

lmores commented 3 years ago

Running tests from the current master branch (5106b8e624edf638ea99ad4a2f2ddb903b37d4a3) I get the following failure:

Failures:
1) FileInfo should compute the file path properties from the parsed file
  Message:
    Expected '/home/<OMISSIS>/dgeni-packages/typescript/mocks/tsParser/importedSrc.ts' to be 'tsParser/importedSrc.ts'.
  Stack:
    Error: Expected '/home/<OMISSIS>/dgeni-packages/typescript/mocks/tsParser/importedSrc.ts' to be 'tsParser/importedSrc.ts'.
        at UserContext.<anonymous> (/home/<OMISSIS>/dgeni-packages/typescript/src/services/TsParser/FileInfo.spec.ts:51:36)

508 specs, 1 failure
Finished in 14.077 seconds

Looking at the source code it's not obvious to me why this specific test fails, maybe someone else can fix it quickly.

petebacondarwin commented 3 years ago

Yeah, I just started to see that when I was rebasing https://github.com/angular/dgeni-packages/pull/295. I think you may have stale node_modules?

petebacondarwin commented 3 years ago

Also note that dgeni-packages uses yarn not npm for development.

lmores commented 3 years ago

The node_modules folder was the culpable, thank you.