Update ecmaVersion to 8

[boindil]

This would allow the usage of additional stuff such as the - nowadays widespread - async keyword.

I verified this in a local setup.

312

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[google-cla[bot]]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[boindil]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[google-cla[bot]]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[petebacondarwin]

Thanks for the PR @boindil - could you squash the two commits together and change the commit message to something like:

feat(jsdoc): add support for parsing ES2017 syntax

Fixes #312 

[boindil]

@petebacondarwin how would I do that? As far as I know you should have the option to squash the commits on acceptance of the PR. Or would you like me to create a new PR with a single commit message?

[petebacondarwin]

@boindil - yes, in this case I think that the "squash and merge" button would suffice since after squashing there would only be a single commit to merge, and I can update the message accordingly at that point. But more generally, we like to keep the commits from the PR as much as possible, and sometimes it is necessary to squash just a few of the commits, which this button does not support. So the normal approach is to rebase your PR branch on the master branch and do the squashing and rewriting of commit messages there before force-pushing back to GitHub. You can do this via the command line:

git checkout patch-1
git rebase -i master
# a text editor should open to allow you to modify the commits
# in this you can also choose to reword commits, which will open a text editor as necessary
git rebase --continue     # as necessary
git push --force-with-lease

I suspect from the fact that your branch is called patch-1 that you created this PR via the Github UI, which may be why you are not aware of this command line approach?

[boindil]

@petebacondarwin yup, I did this by using github. However I did never use the rebase command before, so thanks for the clarification :)