angular / flex-layout

Provides HTML UI layout for Angular applications; using Flexbox and a Responsive API
MIT License
5.9k stars 772 forks source link

fxHide/fxShow adds style="display:initial" #1256

Closed DavidMarquezF closed 4 years ago

DavidMarquezF commented 4 years ago

Bug Report

I use fxLayout to handle responsiveness in the tables of my app (ex: fxHide fxShow.gt-sm to a header and column).

When I update flex layout from beta.29 to beta.30 all the layouts using fxHide and fxShow get added a style tag with display: initial, which overrides display:flex and messes the positioning of the labels.

I'm not sure if this is intentional or a bug.

In beta.29:

image

In beta.30 (all the columns but the farrow column use fxHide and fxShow):

image

What is the expected behavior?

If it's not the expected behavior, it shouldn't add display:initial when using fxHide and fxShow and there is a display:flex style

What is the current behavior?

fxHide/fxShow adds display:initial style which overrides display:flex.

What are the steps to reproduce?

Providing a StackBlitz (or similar) is the best way to get the team to see your issue.

I don't know why but the starter stackblitz wasn't working for me so I used another seed: reproduction

What is the use-case or motivation for changing an existing behavior?

It messes up all the tables in my app by just updating flex-layout

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 9 Material: 9.2.3 FlexLayout: 9.0.0-beta.30

Is there anything else we should know?

DavidMarquezF commented 4 years ago

Sorry I didn't see that this has already been fixed in #1250

angular-automatic-lock-bot[bot] commented 4 years ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.