angular / in-memory-web-api

The code for this project has moved to the angular/angular repo. This repo is now archived.
MIT License
1.18k stars 231 forks source link

Add option to disable content encapsulation in response body #123

Closed ycintre closed 7 years ago

ycintre commented 7 years ago

This feature add a config option (dataEncapsulation) to enable/disable content encapsulation in the response body.

The option work like this:

This closes issue #112

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


ycintre commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

wardbell commented 7 years ago

Hmm. I was resistant at first. But

I will have to close this PR because I'm in the middle of adding HttpClient support andI can't take your PR because too much is changing.

But I will offer it in that forthcoming PR #130

wardbell commented 7 years ago

And as of v0.5, "no encapsulation" is the default :-)