Closed digitalpardoe closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
go/cla#troubleshoot
.I signed it!
CLAs look good, thanks!
any news with this?
I'm sorry but I do not see that this PR addresses the concern in issue #162 nor does it change the functionality in any way. It seems to simply spread the decision logic over two functions where one sufficed before.
Please explain what I am missing.
I'm closing the PR as it hasn't been addressed for six months and I'm no longer in a position where I have availability to discuss it further.
If someone else would like to pick it up then you're more than welcome.
Whilst issues caused by the current functionality, https://github.com/angular/angular/issues/22623 or #162 for example, can be solved through the use of a custom
genId
it strikes me that most developers who use in-memory-web-api will:genId
In the case of 1 this PR changes nothing and in the cases of 2 and 3 it improves the functionality and developer experience.