search

angular / in-memory-web-api

The code for this project has moved to the angular/angular repo. This repo is now archived.
MIT License
1.18k stars 232 forks source link

upgrade to rxjs v6 #185

Closed IgorMinar closed 6 years ago

IgorMinar commented 6 years ago

CI is green because it doesn't run tests :-(

IgorMinar commented 6 years ago

I also sent out https://github.com/angular/in-memory-web-api/pull/186 to test if the CI tests fail on master already... and the tests do pass there.

googlebot commented 6 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.