search

angular / in-memory-web-api

The code for this project has moved to the angular/angular repo. This repo is now archived.
MIT License
1.18k stars 231 forks source link

fix: add generic type for ModuleWithProviders #245

Open CaerusKaru opened 4 years ago

CaerusKaru commented 4 years ago

Ref: https://github.com/angular/angular/pull/33217

CaerusKaru commented 4 years ago

cc @IgorMinar @brandonroberts @kara

clark-stevenson commented 4 years ago

Hey guys, would it be possible to take a look at this PR? When trying to update to Angular 9, I get this error and was going to write a ticket but I guess @CaerusKaru has fixed it here (appreciated!)

brandonroberts commented 4 years ago

I don't have access to merge anything here, so it will have to be merged before I can publish a release

aparna999 commented 4 years ago

cc @IgorMinar @brandonroberts @kara Any plans to release this fix? Thanks. Aparna

baburner commented 4 years ago

cc @IgorMinar @brandonroberts @kara Any plans to release this fix? Thanks. Aparna

Might be good to know! Otherwise we have to find a replacement for the in-memory-web-api when migrating to Angular 9

(And we can't wait forever ;) )

brandonroberts commented 4 years ago

Thanks for your patience.

I'll merge it locally, publish a new version, and open a PR for those changes. I'll update here when it's done

brandonroberts commented 4 years ago

0.10.0 has been published to npm with #251 containing those changes

aparna999 commented 4 years ago

0.10.0 has been published to npm with #251 containing those changes

Thank you. Works now