angular / material-start

Starter Repository for AngularJS Material
https://angularjs-material-start.web.app
MIT License
2.21k stars 1.21k forks source link

fix babel issue "Unknown option: direct.0" [RESOLVED] #165

Closed angelomichel closed 6 years ago

angelomichel commented 7 years ago

Fix for issue: https://github.com/angular/material-start/issues/163

marconi1992 commented 7 years ago

This fix works for me, Thanks @angelomichel

EladBezalel commented 6 years ago

@angelomichel can you rebase?

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


angelomichel commented 6 years ago

I signed it!

@EladBezalel I resolved the conflicts.

googlebot commented 6 years ago

CLAs look good, thanks!

EladBezalel commented 6 years ago

@angelomichel can you please squash the commits together?

angelomichel commented 6 years ago

Hey @EladBezalel.

I double-checked my commits and the latest version. Turns out the current master version uses traceur which solves the issue. For future reference, anyone who has this issue, just update material-start and make sure to do a freshnpm i. I have verified this is at both my MacBooks.

I will close this PR.