angular / material-start

Starter Repository for AngularJS Material
https://angularjs-material-start.web.app
MIT License
2.21k stars 1.21k forks source link

Added package-lock.json to gitignore file and fixed the npm postinstall… #179

Closed ReddragonLR closed 6 years ago

ReddragonLR commented 7 years ago

Added package-lock.json to gitignore file and updated the postinstall npm script to remove everything from global installation besides the jquery as this was breaking the npm install process

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


ReddragonLR commented 7 years ago

CLA signed...

googlebot commented 7 years ago

CLAs look good, thanks!

Splaktar commented 6 years ago

I am seeing the Attempted to compile "angular-animate" as a global module, but it looks like an external module. You'll need to remove the global option to continue. error on postinstall.

Splaktar commented 6 years ago

Thank you for letting us know about this issue! It's been fixed in https://github.com/angular/material-start/commit/bbd3f569925283d186b9dac9f2612e8339e70728.