angular / material-start

Starter Repository for AngularJS Material
https://angularjs-material-start.web.app
MIT License
2.21k stars 1.21k forks source link

Update README.md #182

Closed r0zar closed 6 years ago

r0zar commented 6 years ago

Fix markdown.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


r0zar commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

EladBezalel commented 6 years ago

@r0zar what's the purpose of this change?

r0zar commented 6 years ago

To fix a broken image link in the docs.

On Sun, Oct 22, 2017 at 11:47 AM, Elad Bezalel notifications@github.com wrote:

@r0zar https://github.com/r0zar what's the purpose of this change?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angular/material-start/pull/182#issuecomment-338491542, or mute the thread https://github.com/notifications/unsubscribe-auth/AEcJch6TeG_n1gjDc9KznUId5av-YGuPks5su3GXgaJpZM4P5fGZ .

EladBezalel commented 6 years ago

I can see totally fine.. can you attach a screenshot?

r0zar commented 6 years ago

Check the angular:es6-tutorial branch. It's the one people are linked to from the popular https://material.angularjs.org/latest/getting-started docs for ES6. (Learn with Material-Start: 10-step Tutorial (es6))

r0zar commented 6 years ago

That particular image link is broken on a few of the step-* tags of the tutorial, but the initial page after being linked from the official docs is probably most important.

r0zar commented 6 years ago

Thanks Elad!

EladBezalel commented 6 years ago

@r0zar thank you :)