search

angular / material-start

Starter Repository for AngularJS Material
https://angularjs-material-start.web.app
MIT License
2.21k stars 1.21k forks source link

Unhandled rejection #188

Closed allentc closed 5 years ago

allentc commented 6 years ago

When $mdBottomSheet in app/src/users/components/details/UserDetails.js is dismissed without selecting one of the items Chrome will log a "Possibly unhandled rejection: undefined" error with AngularJS 1.6.x. The solution is to add:

.catch(angular.noop);

on the end of the callback chain.

Splaktar commented 5 years ago

Was this on master or one of the branches?

allentc commented 5 years ago

I imagine I pulled master at the time. I just tried to reproduce this with the master tree (7525f1622d52a938eaf51c5a10953ea9047e031b )I have and did not see the unhandled rejection report in Chrome. Sorry I can't provide precise information.

Splaktar commented 5 years ago

OK, great, thank you for the quick response! I think that this has been resolved.

Splaktar commented 5 years ago

It looks like this might have been in the typescript branch. Fixed there in https://github.com/angular/material-start/commit/7753d5a8e995a26403dd0ce6e9487ac79a931e49.