search

angular / material

Material design for AngularJS
https://material.angularjs.org/
MIT License
16.54k stars 3.39k forks source link

build: interimElements and Layout code not deterministically ordered #11727

Open Splaktar opened 5 years ago

Splaktar commented 5 years ago

Bug, enhancement request, or proposal:

Bug

CodePen and steps to reproduce the issue:

CodePen Demo which demonstrates the issue:

https://github.com/angular/bower-material/commit/31ac6b3046de682d60534d7bdfd81d9f48161049#diff-df9d3e2ee1137430619e1984b3c34f3b

Detailed Reproduction Steps:

  1. Merge a change into the master branch
  2. Then check that the code in bower-material/modules/closure/core/core.js is re-ordered

What is the expected behavior?

The order of the code is deterministic.

What is the current behavior?

The order of the code is non-deterministic. In this case, the order of the src/core/services/layouts and src/core/services/interimElement code was swapped.

What is the use-case or motivation for changing an existing behavior?

So that only real changes show up in the module diffs.

Which versions of AngularJS, Material, OS, and browsers are affected?

Is there anything else we should know? Stack Traces, Screenshots, etc.

Related to #11502.

Splaktar commented 4 years ago

Lowering priority since g3 sync has stopped.