angular / material

Material design for AngularJS
https://material.angularjs.org/
MIT License
16.55k stars 3.39k forks source link

Angular 1.4.* & 1.3.16 breaks md-menu enter animation #3527

Closed dani3l closed 9 years ago

dani3l commented 9 years ago

Since angular 1.4 and 1.3.16 md-menu grow animation does not work. I've checked the change log and found that commit: https://github.com/angular/angular.js/commit/0adc0364265b06c567ccc8e90a7f09cc46f235b2

Hope that someone can look at it.

dani3l commented 9 years ago

Another component that don't behave well since 1.3.16 (and 1.4) is the md-tabs dynamic height animation


Update:

Bug is resolved in angular 1.4.2 (I just tried the latest version from bower - v1.4.2-build.4087+sha.e51024e)

ThomasBurleson commented 9 years ago

@dani3l - Please provide more information regarding the issue that you are having.

Note that that latest versions of Angular Material (master) should be fully compatible with Angular 1.4.x and animations.


Please provide a CodePen or Plunkr that demonstrates this issue. Here are some starter demo templates that you can use/fork:

dani3l commented 9 years ago

Hi @ThomasBurleson, thanks for the codepen starter. I'm using v0.10.0 of angular material (latest on bower)

With angular.js 1.4.1: http://codepen.io/anon/pen/aOqpwQ With angular.js 1.3.16: http://codepen.io/anon/pen/gpvgxP As you can see the menu just fading in

With angular.js 1.3.15: http://codepen.io/anon/pen/XbZpeP Works beautifully, as it should

fxck commented 9 years ago

seems to be broken still in 1.4.2 for me, even with the build you mentioned

ThomasBurleson commented 9 years ago

@rschmukler - can you confirm this is (a) an issue with Menu, and (b) related to $$rAF. Thx... more importantly, it would be nice to confirm this is not a Angular Material issue but an AngularJS issue.