$mdDialog doesn't hide - Githubissues

angular / material

Material design for AngularJS

https://material.angularjs.org/

MIT License

16.55k stars 3.39k forks source link

$mdDialog doesn't hide #7083

Closed asazanowicz closed 8 years ago

asazanowicz commented 8 years ago

Hi. I have a problem with mdDialog. Dialog appears on error with all data I passed. But when I try to close it on ng-click = closeDialog, nothing happens. Here is a code: http://plnkr.co/edit/YAvQVPR6emgRf8gL9xS7?p=catalogue AngularJS v1.4.7 Angular Material v0.11.4

tonyawad88 commented 8 years ago

@AndreiSazanovich I would recommend using angular material team base codepen and then add your html/js/css to it. https://codepen.io/team/AngularMaterial/pen/RrbXyW

Plus I strongly recommend going to the latest version of Angular Material, there are lots of improvements and more stability.

devversion commented 8 years ago

I'm not sure, you posted the complete Plnkr?

There are many things missing:

No includes for angular, material and your other scripts
No Angular App initialization in a document element like <body> (ng-app="MyApp");
A body, which holds the template (using text/ng-template or a inline-js template)
No module creation in the Javascript (angular.modulue('MyApp'))
You create a service from scratch using a unresolved variable (servicesModule)

devversion commented 8 years ago

Closing this, because the demo is completely wrong / invalid. In addition to that, the hiding of a dialog works fine for me. If there are any updates, please let me know!

asazanowicz commented 8 years ago

Yes. It was completely another problem. Thanks, guys

-----Original Message----- From: "Paul Gschwendtner" notifications@github.com Sent: ‎2/‎28/‎2016 18:40 To: "angular/material" material@noreply.github.com Cc: "AndreiSazanovich" info@bilinksoft.com.pl Subject: Re: [material] $mdDialog doesn't hide (#7083)

Closing this, because the demo is completely wrong / invalid. In addition to that, the hiding of a dialog works fine for me. If there are any updates, please let me know! — Reply to this email directly or view it on GitHub.