search

angular / ngSocket

WebSocket support for angular
Apache License 2.0
204 stars 25 forks source link

add onClose callbacks #29

Open fotoflo opened 9 years ago

fotoflo commented 9 years ago

HI! These are important, so that we can notify our controllers that the websocket has closed. Is there any plan to add onClose handlers?

fotoflo commented 9 years ago

I basically copied the onOpen code to work for onClose. Seems to be working. How do i push it?

ri0t commented 9 years ago

done the same, should've looked first. you do a pull request for that, in a fork, usually. there already is one: https://github.com/angular/ngSocket/pull/22 here's mine: https://github.com/angular/ngSocket/pull/31

I also made reconnect do connect actually (helps A LOT - at least during development :neckbeard: ) There's a better one here: https://github.com/angular/ngSocket/pull/23

So, please, @jeffbcross , @btford , @begriffs , @IgorMinar - can someone of you acknowledge this or that pull request and squat this easy issue?? :)