Closed josephliccini closed 5 years ago
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.
. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
@CaerusKaru thanks for merging!
When do you think this could be released to NPM?
The current behavior is that the "events" and "keycodes" property are allowed an array of one item.
The new behavior is that these properties now may have an array of any length.
Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines: https://github.com/angular/preboot/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
What modules are related to this pull-request
[ ] server side
[ ] client side
[ ] inline
[x] build process
[ ] docs
[ ] tests
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) remove unused proxy imports from some test files A TypeScript typings fix.
What is the current behavior? (You can also link to an open issue here) In the
EventSelector
interface, only arrays of one item are allowed forkeyCodes
andevents
.What is the new behavior (if this is a feature change)? In the
EventSelector
interface, arrays of varying length are allowed forkeyCodes
andevents
.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No
Other information: