angular / preboot

Coordinate transfer of state from server to client view for isomorphic/universal JavaScript web applications
MIT License
382 stars 51 forks source link

fix: Illegal invocation calling window.getComputedStyle #146

Open jsaguet opened 2 years ago

jsaguet commented 2 years ago

This is a fix for #135

I've tested this change in an application of my own that was affected by this error and it seems to be working properly this way.

Illegal invocation error is thrown as described in #135

pavelrazuvalau commented 2 years ago

Hello @CaerusKaru @jsaguet!

Do you have any updates about the PR? We're trying to upgrade Angular 12 to the latest minor version. Unfortunately, we're not able to downgrade Angular to 12.1.4 because we use @angular-builders/custom-webpack which uses the latest minor version of Angular by default and the issue is blocking the Angular upgrade.

Thank you!

linusschwab commented 2 years ago

Hi @jsaguet

Thanks a lot for the fix! Are there any updates on this? Looks like the missing CLA might prevent this PR from being merged.

rezonant commented 2 years ago

@jsaguet Could you sign the CLA?

jsaguet commented 2 years ago

I already did