angular / protractor-accessibility-plugin

Runs a set of accessibility audits
MIT License
266 stars 37 forks source link

Allow users to pass in auditConfiguration objects #5

Closed jamsea closed 7 years ago

jamsea commented 8 years ago

Allow users to configure https://github.com/GoogleChrome/accessibility-developer-tools

Also fixed a typo (replace ; with ,) which was causing the plugin to fail.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


jamsea commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

jamsea commented 7 years ago

Hey @sjelin is this safe to merge still? We're still using a forked version of protractor-accessibility-plugin, be great to get this into master. Cheers!

sjelin commented 7 years ago

Sorry - I forgot about the PR! Will do a release in a few minutes