search

angular / protractor-accessibility-plugin

Runs a set of accessibility audits
MIT License
267 stars 37 forks source link

Run audits on every page #9

Closed contolini closed 7 years ago

contolini commented 8 years ago

Thanks for the awesome plugin! One question: Why are audits run on teardown and not against every page? In our project it makes more sense to run them on every page load instead of just on the last page at the very end.

It's pretty easy to run them against every page (see this PR) but I'm guessing there was a reason this plugin wasn't implemented this way?

sjelin commented 7 years ago

Hi! Sorry for the extremely slow response, but I forgot to check notifications on this page.

The reason we don't do onPageLoad is because the angular app often hasn't finished rendering yet. And even if you wait for it to finish rendering, because the page is dynamic, often times important UI elements don't show up until the user interacts with the page. Ideally, we would run the audit continuously, or at least on page unload. We're still working out the details here but if you want to use onPageLoad feel free to use a forked version!

contolini commented 7 years ago

Makes sense! 👍

sachams commented 7 years ago

Hi @contolini and @sjelin - I have written a plugin which allows you to test pages on demand. Have a look at https://github.com/E1Edatatracker/protractor-axe-report-plugin

I'm not sure if this was the direction that this plugin was going so I didn't fork it. What do you think?

emiliogarza commented 6 years ago

Hi @sjelin is there any progress with working out the details of allowing multiple pages? Is a browser.waitForAngular() a possible solution to the finish rendering problem?