angular / protractor

E2E test framework for Angular apps
http://www.protractortest.org
MIT License
8.75k stars 2.31k forks source link

Verbose wait timeouts #422

Closed bunnielovekins closed 10 years ago

bunnielovekins commented 10 years ago

Currently, it can be useful to use a wait instead of an expect in some cases, working in mostly the same way. However, in the event that one of these waits times out, the only error message given is that it timed out, with no additional information given. Perhaps a third argument could be given to the wait function to allow a custom error message provided by the user? (of course, maybe I'm misunderstanding expect and it retries like wait anyway. Not sure, read the docs but didn't see much) (also, this might be better aimed at webdriver. Not sure.)

mattwynne commented 10 years ago

It looks to me like the webdriver function gives you exactly that: https://code.google.com/p/selenium/source/browse/javascript/webdriver/webdriver.js#540

bunnielovekins commented 10 years ago

Balderdash, I get confused sometimes between webdriver and protractor, specifically where I should look for docs. Thanks for the help, looks like the issue was in my head.