search

angular / router

The Angular 1 Component Router
MIT License
665 stars 135 forks source link

Problem running examples with ng-outlet #291

Open johnkit opened 9 years ago

johnkit commented 9 years ago

I am having problems with the 1.x examples. In the “hello” case, for example, it looks like you replaced “ng-viewport’ with “ng-outlet” last week (2015-04-22), however, in my browser, that directive is not getting updated with anything. I am using the angular version installed by npm (1.3.15). Am I missing something?

nikaspran commented 9 years ago

There are a number of issues right now that make the router not actually work.

See #292, #293

tynman commented 9 years ago

I scheduled myself to do a presentation on the new router in two days. Then I read this. Oops! Should be a fun one. ;-)

nikaspran commented 9 years ago

@tynman I'm in the same boat, except my presentation is in three weeks :)

Perhaps check out an earlier version? I'm not sure, but I think 0.4.x might work.

btford commented 9 years ago

@tynman @nikaspran – I'm trying to follow up on issues quickly. Hoping to help your presentations go well. :)

292 was merged, #293 needs unit tests. If you have other problems, feel free to file issues and ping me so I see em.

nikaspran commented 9 years ago

No problem - if you need anything, I'm here to help :)

On Wed, Apr 29, 2015, 07:38 Brian Ford notifications@github.com wrote:

@tynman https://github.com/tynman @nikaspran https://github.com/nikaspran – I'm trying to follow up on issues quickly. Hoping to help your presentations go well. :)

— Reply to this email directly or view it on GitHub https://github.com/angular/router/issues/291#issuecomment-97301983.

corydorning commented 9 years ago

I see that both issues have now been merged. Any plans for a new release soon?

ahundiak commented 9 years ago

Just seems strange that the examples and documentation were changed to ng-outlet and released but the actual code in dist still uses ng-viewport. Was this perhaps an oversight? The code under src uses ng-outlet.

nikaspran commented 9 years ago

It's because there hasn't been a new release. They'll sync up in 0.5.4 or whatever the next tag is going to be.

corydorning commented 9 years ago

Understood...any plans for a new release in the near future so the documentation matches the code?

DeborahK commented 9 years ago

+1 would like to see the code match the documentation match the sample apps. I just gave a talk on this on Tuesday and was able to get one of the sample apps to work (the Monty Python one), but not my sample app.