search

angular / router

The Angular 1 Component Router
MIT License
665 stars 135 forks source link

Test failed on 'ngOutlet should not reactivate a parent when navigating between child components with different parameters' #300

Closed Simon-Li closed 9 years ago

Simon-Li commented 9 years ago

@btford looks there is a bug in the following line that caused the test failed as shown blow. Just fixed it, may I create a pull request for it?

registerComponent('parent', 'parent { }', ParentController);

Chrome 42.0.2311 (Mac OS X 10.10.0) ngOutlet should not reactivate a parent when navigating between child components with different parameters FAILED TypeError: Cannot read property 'canonicalUrl' of undefined at Grammar.recognize (/opt/angular-router/dist/router.es5.js:1491:93) at RootRouter.recognize (/opt/angular-router/dist/router.es5.js:790:28) at RootRouter.navigate (/opt/angular-router/dist/router.es5.js:718:30) at RootRouter.$$rootRouter.navigate (/opt/angular-router/dist/router.es5.js:104:16) at Object. (/opt/angular-router/test/router-viewport.es5.spec.js:95:13) Chrome 42.0.2311 (Mac OS X 10.10.0): Executed 44 of 44 (1 FAILED) (2.263 secs / 2.247 secs)

nikaspran commented 9 years ago

This is fixed in #298 (This line, specifically)

Simon-Li commented 9 years ago

Yeap, close it.