angular / router

The Angular 1 Component Router
MIT License
665 stars 135 forks source link

allow to pass attributes from parent component via ngOutlet directive #406

Open caricsvk opened 8 years ago

caricsvk commented 8 years ago

ngOutlet is missing implementation for passing attributes to child component. The solution bellow might not be sufficient so I suggest to look at it and rewrite it. The 'if' condition might be problematic. I left a TODO comment there.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


caricsvk commented 8 years ago

@googlebot I signed it!

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.