angular / ts-api-guardian

MIT License
15 stars 15 forks source link

fix: handle paths and line endings in a cross-platform compatible way… #19

Closed steidinger closed 6 years ago

steidinger commented 7 years ago

… (#13)

Mostly I was able to normalize paths and line endings. However some files in the integration tests used mixed line endings which the eol module was unable to normalize. Therefore I decided to ignore line endings in those tests.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


steidinger commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

dherges commented 7 years ago

@steidinger @chuckjaz Ok, this was on 15th of Feb ... is there any chance that his wiill get published?

alexeagle commented 6 years ago

Sorry this was lost!

ts-api-guardian is moving to the main angular/angular repository. Please re-open your PR there.

You can CC me on it and I'll make sure your patch is merged this time.