search

angular / ts-minify

A tool to aid minification of Typescript code, using Typescript's type information.
Apache License 2.0
121 stars 7 forks source link

Bug fix prop name #22

Closed dariajung closed 9 years ago

dariajung commented 9 years ago

Issue #21

mprobst commented 9 years ago

I would try and not get too hung up on the whole generateNextPropertyName thing; if it's easier just don't use 0-9 in your alphabet - it's not really that useful to fiddle with this before we can measure end-to-end minification performance (gzipped result from minifying e.g. Angular with this). IMHO it's more interesting to spend some time on the externs/internal symbols/etc topic (and don't forget your talk!).

rkirov commented 9 years ago

LGTM, @mprobst I asked Daria to simply add numerics and '$', '_', assuming it shouldn't be too complicated. Lets merge this and move on.

Daria, if more bugs appear in the generation, feel free to reduce the alphabet if easier that fixing the bug.