Remove eventBinding and propertyBinding

[a-stewart]

This removes the Angular definitions of event and property bindings, in favour of those provided by the default HTML extension in VS Code.

This fixes #1725

See https://github.com/angular/vscode-ng-language-service/issues/1725#issuecomment-1671803141 for justification

[atscott]

@a-stewart Hey, sorry I hadn't pinged you on the issue report. I've been working with the syntaxes a bit more recently to support the control flow and realized that removing these isn't a very good option. This would remove the expression highlighting on the value side. On the key side, we don't really need any special highlighting, but the value side includes the expression.ng which includes a lot more Angular-specific template syntax highlighting.

[a-stewart]

No worries

Another approach which could be taken would be to have another file, eg, template-tags.json, which we inject into soure.html meta.tag or something like that.

[atscott]

Another approach which could be taken would be to have another file, eg, template-tags.json, which we inject into soure.html meta.tag or something like that.

Yea, that's probably the best path forward. We'd have more control there to include/exclude the syntaxes in certain contexts.

[a-stewart]

Let me have a quick play and then I'll get back to you if it seems to work.

[a-stewart]

I need to call it a day now as it is late here, but #1993 (WIP) seems to work as expected.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}