angular / vscode-ng-language-service

Angular extension for Visual Studio Code
MIT License
781 stars 117 forks source link

incorrectly importing default exported component via quickfix #2014

Closed DimitriTsikaridze closed 4 months ago

DimitriTsikaridze commented 8 months ago

🐞 bug report

Is this a regression?

Yes, the previous version in which this bug was not present was: .... ### Description A clear and concise description of the problem... If the bug is caused or experienced by a particular source code, please provide a minimal reproduction of that source code. ## Bug Type What does this bug affect

Reproduction

Steps to reproduce the behavior:

  1. Create component and add default export to it like so export default class SignInFormComponent {
  2. write component selector inside other component html and then click option to quick-fix it

Expected behavior

A clear and concise description of what you expected to happen. it should import component with its default export name instead of import { default } from "./sign-in-form/sign-in-form.component"; it should be import SignInComponent from "./sign-in-form/sign-in-form.component"

Logs

Log file gives us deep insight into the behavior and performance of the extension. If the issue is a performance problem or an error occured, please provide the output of the log file below.

Set Angular Log level to verbose.





Screenshots

image image

If applicable, add screenshots to help explain your problem.

Example Screenshot

🌍 Your Environment

Angular Version:





Extension Version:





VSCode Version:





Operating System:





Extension options:





Anything else relevant?

eneajaho commented 4 months ago

This can be closed as it was fixed in the last release πŸŽ‰

PR https://github.com/angular/angular/pull/56432

angular-automatic-lock-bot[bot] commented 2 months ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.