angular / vscode-ng-language-service

Angular extension for Visual Studio Code
MIT License
773 stars 116 forks source link

Help understand how a language service detects an Angular project #2069

Closed Bilal-io closed 2 months ago

Bilal-io commented 2 months ago

🚀 feature request

Description

The Zed Edit project is looking to implement support for Angular, and there is a discussion here to under what is the best way to detect an Angular project.

I did my best to understand and describe how the VS Code Language Service extension does it in the issue linked above, but I am not sure how correct/wrong I am.

Feature Type

Describe the solution you'd like

Assistance with the Zed editor if possible, or helpful guidance

Describe alternatives you've considered

None

Anything else relevant?

None

atscott commented 2 months ago

Your comment is correct. The extension activates on all TS or HTML files. Beyond that, there is short-circuit logic to check that the program for the given document contains @angular/core in the sources (isInAngularProject). There is other short-circuiting logic to check that a given request is in a context which the language service would have any Angular-specific information to avoid needlessly asking the language service for information when it won't have anything useful.

angular-automatic-lock-bot[bot] commented 1 month ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.