angular / webdriver-manager

A binary manager for E2E testing
MIT License
224 stars 116 forks source link

Fix macOS arch checks. #493

Open LeviticusMB opened 3 years ago

LeviticusMB commented 3 years ago

Code checked if filename matches macos. geckodriver-v0.29.1-macos-aarch64.tar.gz matches, even though geckodriver-v0.29.1-macos.tar.gz would be the correct archive to download.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

LeviticusMB commented 3 years ago

@googlebot I signed it!

google-cla[bot] commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cnishina commented 3 years ago

I'll try to review this tomorrow.

LeviticusMB commented 3 years ago

... and? 😁