angular / webdriver-manager

A binary manager for E2E testing
MIT License
224 stars 116 forks source link

Fix the vulnerabiltiy issue discussed in #499 #500

Open paimon0715 opened 3 years ago

paimon0715 commented 3 years ago

Fix the vulnerabiltiy issues discussed in https://github.com/angular/webdriver-manager/issues/499.

Ugrade adm-zip ^0.4.9 ➔ ^0.5.2, since adm-zip@0.5.2(>=0.5.2) has fixed the vulnerability SNYK-JS-ADMZIP-1065796.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

paimon0715 commented 3 years ago

@googlebot I signed it!

google-cla[bot] commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

paimon0715 commented 3 years ago

@StanislavKharchenko It would be better if webdriver-manager can fix this issue in versions 12.1. , 12.0. , 10.3.*, and release them to npm. Then this vulnerbility patch can be automatically propagated into a large amount of downstream projects :) Please check it. Thanks again.