search

angular / zone.js

Implements Zones for JavaScript
https://github.com/angular/angular/tree/master/packages/zone.js/
MIT License
3.25k stars 408 forks source link

build: upgrade to pass jasmine 3.3 test #1185

Closed JiaLiPassion closed 5 years ago

JiaLiPassion commented 5 years ago

jasmine 3.3 will ignore process.unhandledRejection eventListeners, so some of our Promise test will fail, in this PR, I restore the process.unhandledRejection to make our test pass.

JiaLiPassion commented 5 years ago

@IgorMinar , sure, I will check it, thanks!

JiaLiPassion commented 5 years ago

@IgorMinar, now the bluebird test passed, and CI failed because the Firefox 65 issue, please review, thanks!

IgorMinar commented 5 years ago

can you please send a separate PR to drop the old FF and make CI green again. thanks

JiaLiPassion commented 5 years ago

@IgorMinar, yeah, the PR is here, I am trying to make it work there, https://github.com/angular/zone.js/pull/1191, thanks